ddl: add slow operations log to add indices, make trouble shooting easier. #7060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tidb into logs_metrics_for_adding_indices
shenli
reviewed
Jul 16, 2018
config/config.go
Outdated
| SlowThreshold: 300, | ||
| ExpensiveThreshold: 10000, | ||
| QueryLogMaxLen: 2048, | ||
| DDLSlowOprThreshold: 300, |
config/config.toml.example
Outdated
| @@ -63,6 +63,8 @@ expensive-threshold = 10000 | |||
| # Maximum query length recorded in log. | |||
| query-log-max-len = 2048 | |||
|
|
|||
| ddl-slow-opr-threshold = 300 | |||
ddl/index.go
Outdated
| err := iterateSnapshotRows(w.sessCtx.GetStore(), w.table, txn.StartTS(), taskRange.startHandle, | ||
| func(handle int64, recordKey kv.Key, rawRow []byte) (bool, error) { | ||
| oprEndTime := time.Now() | ||
| w.logSlowOperations(oprEndTime.Sub(oprStartTime), "iterateSnapshotRows in fetchRowColVals is slow", 0) |
There was a problem hiding this comment.
"is slow" is redundant with "SLOW-OPERATIONS".
ddl/index.go
Outdated
| @@ -624,6 +642,7 @@ func (w *addIndexWorker) backfillIndexInTxn(handleRange reorgIndexTask) (nextHan | |||
| } | |||
| return nil | |||
| }) | |||
| w.logSlowOperations(time.Since(oprStartTime), "backfillIndexInTxn is slow", 3000) | |||
There was a problem hiding this comment.
Could we define a constant for 3000 ？
coocood
reviewed
Jul 16, 2018
config/config.go
Outdated
| @@ -84,6 +84,9 @@ type Log struct { | |||
| SlowThreshold uint `toml:"slow-threshold" json:"slow-threshold"` | |||
| ExpensiveThreshold uint `toml:"expensive-threshold" json:"expensive-threshold"` | |||
| QueryLogMaxLen uint `toml:"query-log-max-len" json:"query-log-max-len"` | |||
|
|
|||
| // DDLSlowOprThreshold is the threshold of ddl slow operations. | |||
| DDLSlowOprThreshold uint `toml:"ddl-slow-opr-threshold" json:"ddl-slow-opr-threshold"` | |||
There was a problem hiding this comment.
I think if we make this configurable, it's better to use HTTP API, it doesn't require a restart of the server.
There was a problem hiding this comment.
Then the config option can be removed.
shenli
reviewed
Jul 16, 2018
| @@ -624,6 +641,7 @@ func (w *addIndexWorker) backfillIndexInTxn(handleRange reorgIndexTask) (nextHan | |||
| } | |||
| return nil | |||
| }) | |||
| w.logSlowOperations(time.Since(oprStartTime), "backfillIndexInTxn", 3000) | |||
There was a problem hiding this comment.
I think 3s is large enough, so no needs to be configurable.
|
LGTM |
|
/run-all-tests |
crazycs520
added
status/LGT2
coocood
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Log the slow operations in DDL adding indices. It is useful when the adding indices become slow, it can help us to find the problem.
What is the type of the changes? (mandatory)